Fix RTL in AbsoluteLayout #7309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
the
area-layout
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
samhouts
reviewed
May 19, 2022
| bool leftToRight = AbsoluteLayout.ShouldArrangeLeftToRight(); | ||
|
|
||
| // Figure out where we're starting from (the left edge of the padded area, or the right edge) | ||
| double xPosition = leftToRight ? padding.Left + bounds.Left : bounds.Right - padding.Right; |
There was a problem hiding this comment.
Does it make sense to reuse left and right here, since they seem to match?
There was a problem hiding this comment.
definitely, thanks for catching that!
| var measuredSize = manager.Measure(double.PositiveInfinity, 100); | ||
| manager.ArrangeChildren(new Rect(Point.Zero, measuredSize)); | ||
|
|
||
| // We expect that the view hould be arranged on the right |
There was a problem hiding this comment.
Suggested change
| // We expect that the view hould be arranged on the right | |
| // We expect that the view should be arranged on the right |
hartez
suggested changes
May 20, 2022
hartez
approved these changes
May 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix RTL in AbsoluteLayout. Now, setting RTL on AbsoluteLayout will actually right-align its children. Yay!
Thank you EZ for all the layout knowledge and help
Issues Fixed
Fixes #6540