-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Correctly notify CheckBox Color changes #7084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for this like this: https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/Page/PageTests.cs#L67-L84
Preferably we need a way to see if a property changes that a set of handler events fire, but this is technically better as we check for colors.
Updated adding device tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test logic should be cross-platform, so should we move the test into the shared code so it runs on all platforms?
Yeah, moved to shared code to allow run it on all the platforms. Waiting for the build. |
Can you rebase @jsuarezruiz ? |
Description of Change
Correctly notify CheckBox Color changes.
Light

Dark

Issues Fixed
Fixes #6253