[X] Process ContentProperty before Add() #6982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added IEnumerable interface, and Add() methods, to Layouts in MAUI. As the XAML inflaters were trying to Add() before looking for a ContentProperty, 1/ ContentProperty on Layout (like Grid) is completely ignored (but layouts works nonetheless, because of belt and suspenders). 2/ overriding the ContentProperty is ignored (as found in #6944) This PR changes the order of Add() and ContentProperty processing, and restore the expected behavior, without breaking any other unit test. - fixes #6944
StephaneDelcroix
force-pushed
the
fix_6944
branch
from
df9e64f to
f1d55ed
Compare
jsuarezruiz
added
area-xaml
mattleibow
reviewed
May 10, 2022
hartez
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We added IEnumerable interface, and Add() methods, to Layouts in MAUI.
As the XAML inflaters were trying to Add() before looking for a
ContentProperty,
1/ ContentProperty on Layout (like Grid) is completely ignored (but
layouts works nonetheless, because of belt and suspenders).
2/ overriding the ContentProperty is ignored (as found in #6944)
This PR changes the order of Add() and ContentProperty processing, and
restore the expected behavior, without breaking any other unit test.
Issues Fixed