Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Apply default WinUI 3 Styles #6947

Merged
merged 1 commit into from
May 9, 2022
Merged

[Windows] Apply default WinUI 3 Styles #6947

merged 1 commit into from
May 9, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented May 9, 2022 •
edited
Loading

Description of Change

Apply default WinUI 3 Styles.

fix-6209

Issues Fixed

Verified #1738
Fixes #6209

About #1738, currently we have the following resources:
image

  • MauiComboBoxStyle: This resource include a style to allow CharacterSpacing and other details to be used in the title. However, the Picker use directly Microsoft.UI.Xaml.Controls.ComboBox.
  • MauiSliderStyle: Contains a style for the Slider Thumb using an image. The Slider use directly Microsoft.UI.Xaml.Controls.Slider .
  • MauiStepperStyle: There is not something like the Xamarin.Forms UWP Stepper in WinUI. This resource contains a style to define the Stepper using a Grid with two buttons.
  • WindowRootStyle: Here we have some styles to allow to customize the AppBarTitle etc.

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/windows 🪟 labels May 9, 2022
@rmarinho rmarinho requested a review from PureWeen May 9, 2022 12:15
@Redth Redth merged commit 73c85e7 into main May 9, 2022
@Redth Redth deleted the fix-6209 branch May 9, 2022 13:27
@Redth Redth added this to the 6.0.300 milestone May 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.312 Look for this fix in 6.0.312! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees
No one assigned
Labels
fixed-in-6.0.312 Look for this fix in 6.0.312! platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Milestone
6.0.300
Development

Successfully merging this pull request may close these issues.

ListView uses the wrong style in WinUI 3
3 participants
@jsuarezruiz @Redth @samhouts