Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Update ShellHandler #6884

Merged
merged 1 commit into from
May 6, 2022
Merged

[Tizen] Update ShellHandler #6884

merged 1 commit into from
May 6, 2022

Conversation

shyunMin
Copy link
Contributor

@shyunMin shyunMin commented May 6, 2022

Description of Change

This PR includes below changes for fixing some issue and applying review feedback

  • Fix for calculating the size of CollectionView's item and FlyoutItem
  • Replace the icon image sources used for the menu icon in Shell with MaterialIcon
  • Add some options for Tizen platform in the default FlyoutItem template
  • Rename variables native to platform

Issues Fixed

Fixes #

@shyunMin shyunMin force-pushed the update-tizen-shell branch from 2ab7961 to 79b0056 Compare May 6, 2022 08:49
@shyunMin shyunMin force-pushed the update-tizen-shell branch from 79b0056 to 2664dfb Compare May 6, 2022 08:51
@rookiejava
Copy link
Contributor

With this PR, I've confirmed that the issues related to the Shell (raised by our customers) have been resolved. Thanks!

@rmarinho
Copy link
Member

rmarinho commented May 6, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jsuarezruiz jsuarezruiz added the platform/tizen Samsung Tizen Devices (TV) label May 6, 2022
@Eilon Eilon added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label May 6, 2022
@Redth Redth merged commit c06e0a4 into dotnet:main May 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.312 Look for this fix in 6.0.312! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

Assignees
No one assigned
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.312 Look for this fix in 6.0.312! platform/tizen Samsung Tizen Devices (TV)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shyunMin @rookiejava @rmarinho @PureWeen @Eilon @Redth @jsuarezruiz @samhouts