Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Keyboard property in EditorHandlers #686

Merged
merged 7 commits into from
Jun 1, 2021
Merged

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Apr 8, 2021

Description of Change

Implement Keyboard property in EditorHandlers.

Platforms Affected

  • Core
  • iOS
  • macOS
  • Android

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

@rachelkang
Copy link
Member

rachelkang commented May 27, 2021

I'm wondering - can we add the Windows implementation to this PR as well?

Also, there are failing iOS tests - not yet sure if any are related, but thinking the Editor ones might be
IMG_0024

@rachelkang rachelkang self-requested a review May 27, 2021 21:29
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment!

@hartez hartez merged commit a6d35a1 into main Jun 1, 2021
@hartez hartez deleted the editor-keyboard branch June 1, 2021 22:47
lytico pushed a commit to lytico/maui that referenced this pull request Jun 8, 2021
* Implement Keyboard property in EditorHandlers

* Cleanup EditorHandler.Windows.cs

* Add missing bracket

* Fixed failing Editor handler tests

Co-authored-by: Rachel Kang <[email protected]>
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants