[Entry/Win] Fixed cursor jumping to the beginning of a PasswordBox #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
t/bug
jsuarezruiz
approved these changes
May 5, 2022
mattleibow
previously requested changes
May 5, 2022
There was a problem hiding this comment.
Something has gone wrong. Not sure here or before, but the text is all flashy.
Also, to make things easier it might be worth seeing why we assign the text multiple times... I think on each char, we should just be reading the text and replacing with the obfuscated value. When it is a password mode, we should never assign any plain text at all.
I probably should have shown, but it is not obvious on a recording, but if you hold down a key, then the entire textbox freezes and shows all text.
Might be a bit hard to see as my fps probably was not high enough, but each char causes the full plain text to appear. You can see this in one instance here though.
Media1.mp4
Enjoy the typing sounds as I forgot to mute :)
…try control * Password is not longer being set as plain text after the text is transformed
Redth
approved these changes
May 6, 2022
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes an odd behavior where the cursor jumps to the beginning of the entry when:
IsPasswordproperty is set toTrue.TextTransformis setThis PR also includes a validation that avoids the Text being transformed when the
IsPasswordis set toTrueIssues Fixed
Fixes #5401
Fixes #6870