Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility should affect the container if there is one #6828

Merged
merged 1 commit into from
May 5, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Core/src/Handlers/View/ViewHandler.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
using System.Data.Common;
using System.Runtime.CompilerServices;
using Microsoft.Maui.Graphics;
#if __IOS__ || MACCATALYST
using PlatformView = UIKit.UIView;
Expand Down Expand Up @@ -193,7 +191,10 @@ public static void MapIsEnabled(IViewHandler handler, IView view)

public static void MapVisibility(IViewHandler handler, IView view)
{
((PlatformView?)handler.PlatformView)?.UpdateVisibility(view);
if (handler.HasContainer)
((PlatformView?)handler.ContainerView)?.UpdateVisibility(view);
else
((PlatformView?)handler.PlatformView)?.UpdateVisibility(view);
}

public static void MapBackground(IViewHandler handler, IView view)
Expand All @@ -208,7 +209,7 @@ public static void MapFlowDirection(IViewHandler handler, IView view)

public static void MapOpacity(IViewHandler handler, IView view)
{
if(handler.HasContainer)
if (handler.HasContainer)
((PlatformView?)handler.ContainerView)?.UpdateOpacity(view);
else
((PlatformView?)handler.PlatformView)?.UpdateOpacity(view);
Expand Down