Fix operator precedence #6788
Merged
Fix operator precedence #6788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
approved these changes
May 3, 2022
mattleibow
added
t/bug
mattleibow
approved these changes
May 3, 2022
jsuarezruiz
approved these changes
May 3, 2022
Eilon
added
the
legacy-area-controls
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This change fixed an obvious operator precedence issue. It appears to me that the intent of that condition is to ensure
pickeris not null and also allow two different cases for the format strings, but as is written, the code ensurepickeris not null only when it hits the former case.Issues Fixed
Fixes #6402