Fix the file check for the AppxManifest #6770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
the
area-essentials
|
This does not fix the issue with auth as that is not supported it seems: |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
dotMorten
reviewed
May 3, 2022
| @@ -47,7 +48,8 @@ public async Task<WebAuthenticatorResult> AuthenticateAsync(WebAuthenticatorOpti | |||
|
|
|||
| static bool IsUriProtocolDeclared(string scheme) | |||
| { | |||
| var doc = XDocument.Load(PlatformUtils.AppManifestFilename, LoadOptions.None); | |||
| var docPath = FileSystemUtils.PlatformGetFullAppPackageFilePath(PlatformUtils.AppManifestFilename); | |||
| var doc = XDocument.Load(docPath, LoadOptions.None); | |||
There was a problem hiding this comment.
Should you do a file check here? I don’t think an unpackaged WinUI app will have a manifest?
There was a problem hiding this comment.
Good point. Instead of changing behaviour in this PR, I added another step in the larger #3166 issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Just try load the right files for #2702