Fix various measure/layout issues with android flyout #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-layout
Redth
approved these changes
May 2, 2022
hartez
suggested changes
May 2, 2022
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellContentView.cs
Outdated
Show resolved
Hide resolved
hartez
approved these changes
May 2, 2022
mattleibow
requested changes
May 3, 2022
...ontrols/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs
Outdated
Show resolved
Hide resolved
Comment on lines
538
to
542
| public override LP LayoutParameters | ||
| { | ||
| get => base.LayoutParameters; | ||
| set => base.LayoutParameters = value; | ||
| } |
...ontrols/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs
Show resolved
Hide resolved
...ontrols/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs
Show resolved
Hide resolved
mattleibow
approved these changes
May 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix various measure/layouts calls to adhere more correctly to .NET MAUI expectations
Issues Fixed
Fixes #5603