[Android] Fix usage of SimpleViewHolder on COllectionView Header and Footer #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
changed the title
Eilon
added
the
area-controls-collectionview
Redth
approved these changes
May 2, 2022
mattleibow
reviewed
May 3, 2022
| @@ -26,6 +26,8 @@ internal void RealizeContent(View view, ItemsView itemsView) | |||
| { | |||
| Content = CreateHandler(view, itemsView); | |||
| var platformView = Content.ContainerView ?? Content.PlatformView; | |||
jsuarezruiz
approved these changes
May 3, 2022
hartez
approved these changes
May 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Our previous implementation on Forms was creating always a new native element before adding it to SimpleViewHolder, but now we reuse the handler so we need to remove it first from the old ItemContentView before adding it to our new ItemContentView
Issues Fixed
Fixes #5332