[Windows] Correctly size the ImageButton BitmapImage #6663
Conversation
jsuarezruiz
added
t/bug
| nativeImage.Width = imageSourceSize.Width; | ||
| nativeImage.Height = imageSourceSize.Height; | ||
|
|
||
| nativeImage.Width = button.Width > 0 ? platformButton.ActualWidth : imageSourceSize.Width; |
There was a problem hiding this comment.
If ImageButton HeightRequest and WidthRequest properties have been set we use that values on the image. Otherwise, the height and width of the original image size is used.
There was a problem hiding this comment.
I believe EZ added a special value for this: Primitives.Dimension.Unset
The Width/Height properties are already massaged into either Unset or a positive value, so we should probably use that to be consistent.
There was a problem hiding this comment.
Applied changes to use Primitives.Dimension.Unset, also added a sample:
Is working correctly and also resize as expected.
Eilon
added
the
legacy-area-controls
| nativeImage.Width = imageSourceSize.Width; | ||
| nativeImage.Height = imageSourceSize.Height; | ||
|
|
||
| nativeImage.Width = button.Width > 0 ? platformButton.ActualWidth : imageSourceSize.Width; |
There was a problem hiding this comment.
I believe EZ added a special value for this: Primitives.Dimension.Unset
The Width/Height properties are already massaged into either Unset or a positive value, so we should probably use that to be consistent.
Eilon
removed
the
legacy-area-controls
Description of Change
Correctly size the Windows ImageButton BitmapImage.
Issues Fixed
Fixes #4913