Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and fix tvOS checks and annotations and remove PlatformVersion #6636

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Apr 28, 2022

Follow-up to #6237, some of the tvOS version checks got lost there since PlatformVersion.IsAtLeast() which checks both iOS and tvOS was replaced by just checking for iOS.

Fixed that and also removed the PlatformVersion class (follow-up to #5860)

@akoeplinger
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Apr 28, 2022
@akoeplinger akoeplinger force-pushed the platformversion-fixes branch from 74f9f7f to 2a97e3f Compare April 28, 2022 22:54
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 Q on something that seems to violated compile rules before...

Comment on lines -88 to +89
[SupportedOSPlatform("ios13.0")]
[SupportedOSPlatform("ios15.0")]
[SupportedOSPlatform("tvos15.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice a version change... Is this a bug in the macios repo because it should not have compiled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like UINavigationBarAppearance was introduced in iOS13, so looks like a MAUI issue and this should've been called on iOS13?

Copy link
Member Author

@akoeplinger akoeplinger Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was introduced in #3332 so definitely intended for iOS 15, hence the method name.

I'm not an expert here so I'd keep it as is for now and maybe file an issue for someone to consider lowering this to iOS13?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI: The warnings found were all for version 13:

'UINavigationBar.StandardAppearance.set' is   only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos'   13.0 and later.
'UINavigationBarAppearance' is only   supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos' 13.0   and later.
'UIBarAppearance.ConfigureWithOpaqueBackground()'   is only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later,   'tvos' 13.0 and later.
'UIBarAppearance.BackgroundColor' is only   supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos' 13.0   and later.
'UINavigationBarAppearance.TitleTextAttributes'   is only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later,   'tvos' 13.0 and later.
'UINavigationBar.ScrollEdgeAppearance' is   only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos'   13.0 and later.

@mattleibow mattleibow self-assigned this Apr 29, 2022
@mattleibow mattleibow added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Apr 29, 2022
@mattleibow mattleibow added this to the 6.0.300-rc.3 milestone Apr 29, 2022
@mattleibow mattleibow added area-architecture Issues with code structure, SDK structure, implementation details and removed area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions labels Apr 29, 2022
@mattleibow mattleibow merged commit 64432c4 into dotnet:main Apr 29, 2022
@akoeplinger akoeplinger deleted the platformversion-fixes branch April 29, 2022 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-architecture Issues with code structure, SDK structure, implementation details fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants