-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore and fix tvOS checks and annotations and remove PlatformVersion #6636
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
74f9f7f
to
2a97e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 Q on something that seems to violated compile rules before...
[SupportedOSPlatform("ios13.0")] | ||
[SupportedOSPlatform("ios15.0")] | ||
[SupportedOSPlatform("tvos15.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice a version change... Is this a bug in the macios repo because it should not have compiled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like UINavigationBarAppearance was introduced in iOS13, so looks like a MAUI issue and this should've been called on iOS13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code was introduced in #3332 so definitely intended for iOS 15, hence the method name.
I'm not an expert here so I'd keep it as is for now and maybe file an issue for someone to consider lowering this to iOS13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI: The warnings found were all for version 13:
'UINavigationBar.StandardAppearance.set' is only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos' 13.0 and later.
'UINavigationBarAppearance' is only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos' 13.0 and later.
'UIBarAppearance.ConfigureWithOpaqueBackground()' is only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos' 13.0 and later.
'UIBarAppearance.BackgroundColor' is only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos' 13.0 and later.
'UINavigationBarAppearance.TitleTextAttributes' is only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos' 13.0 and later.
'UINavigationBar.ScrollEdgeAppearance' is only supported on: 'ios' 13.0 and later, 'maccatalyst' 13.0 and later, 'tvos' 13.0 and later.
Follow-up to #6237, some of the tvOS version checks got lost there since
PlatformVersion.IsAtLeast()
which checks both iOS and tvOS was replaced by just checking for iOS.Fixed that and also removed the
PlatformVersion
class (follow-up to #5860)