Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebView2 Runtime download link for Blazor MAUI #6492

Merged

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Apr 25, 2022

Description of Change

The WinUI 3 WebView2 control displays a download link for the WebView2 Runtime when it is not installed on the host machine. However, the BlazorWebView control (which wraps the WinUI 3 WebView2 control on Blazor MAUI Windows) did not display the link under the same conditions. This PR fixes the bug that prevented the link from displaying.

Before:
before

After:
after

Issues Fixed

Fixes #6421

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner April 25, 2022 21:33
@MackinnonBuck MackinnonBuck added the area-blazor Blazor Hybrid / Desktop, BlazorWebView label Apr 25, 2022
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MackinnonBuck MackinnonBuck enabled auto-merge (squash) April 26, 2022 16:30
@MackinnonBuck MackinnonBuck merged commit 6397537 into main Apr 26, 2022
@MackinnonBuck MackinnonBuck deleted the mbuck/blazor-maui-webview2-runtime-download-link-fix branch April 26, 2022 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAUI Blazor template (WinUI 3) does not display WebView2 Runtime download link
5 participants