Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AmbigousMatchException between duplicated types Core and Controls #6409

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Fix AmbigousMatchException between duplicated types Core and Controls #6409

merged 2 commits into from
Apr 27, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Apr 22, 2022 •
edited
Loading

Description of Change

Avoid AmbigousMatchException between duplicated types in Microsoft.Maui and Microsoft.Maui.Controls. Renamed IElement from Microsoft.Maui.Controls.

There are similar cases like:

  • LayoutAlignment (Why not an unique type in Core using the Flags attribute?)

Issues Fixed

Fixes #4300

@jsuarezruiz jsuarezruiz added the t/bug Something isn't working label Apr 22, 2022
@mattleibow
Copy link
Member

mattleibow commented Apr 22, 2022 •
edited
Loading

D:\a_work\1\s\src\Controls\tests\Core.UnitTests\ResourceDictionaryTests.cs(140,20): error CS1061: 'IElement' does not contain a definition for 'AddResourcesChangedListener' and no accessible extension method 'AddResourcesChangedListener' accepting a first argument of type 'IElement' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]

@jsuarezruiz jsuarezruiz marked this pull request as ready for review April 25, 2022 14:46
@rmarinho rmarinho merged commit 0cb2944 into main Apr 27, 2022
@rmarinho rmarinho deleted the fix-4300 branch April 27, 2022 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix

Assignees
No one assigned
Labels
fixed-in-6.0.300-rc.3 Look for this fix in 6.0.300-rc.3! t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AmbigousMatchException throwing when a control that inherent from Element is instantiated
5 participants
@jsuarezruiz @mattleibow @StephaneDelcroix @rmarinho @samhouts