[Windows] Fix crash using SwipeView inside CollectionView #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
Redth
reviewed
Apr 19, 2022
| bool CanMeasureContent(FrameworkElement frameworkElement) | ||
| { | ||
| // Measure the SwipeControl before has loaded causes a crash on the first layout pass | ||
| if (frameworkElement is SwipeControl swipeControl && !swipeControl.IsLoaded) |
There was a problem hiding this comment.
Is this exclusive to SwipeControl? Should this just check for a Control that IsLoaded ?
There was a problem hiding this comment.
A far as I reviewed cannot Measure the SwipeControl with left or right items before is loaded, but, not happens in the rest of the controls.
|
Looking forward to this fix! Thanks Javier. |
Redth
approved these changes
Apr 25, 2022
|
What .net Version did this come into? As I am using .net 7.0.3 and I can still see the exception on Windows |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix crash using SwipeView inside CollectionView on Windows.
Issues Fixed
Fixes #6153
Fixes #6401