Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TitleView swapping behavior on Android/WinUI #6195

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Fix TitleView swapping behavior on Android/WinUI #6195

merged 2 commits into from
Apr 18, 2022

Conversation

PureWeen
Copy link
Member

Description of Change

  • Fix Android so swapping out TitleView doesn't crash
  • fix margins on WinUI and Android when set on TitleView
  • Fix WinUI so that the Title hides if the TitleView is set

Issues Fixed

Fixes #6148
Fixes #5944

@PureWeen PureWeen added this to the 6.0.300-rc.2 milestone Apr 18, 2022
@PureWeen PureWeen requested a review from drasticactions April 18, 2022 17:10
@drasticactions
Copy link
Contributor

drasticactions commented Apr 18, 2022 •
edited
Loading

image

image

image

Yep, looks good to me. 👍

@PureWeen PureWeen enabled auto-merge (squash) April 18, 2022 20:46
@PureWeen PureWeen merged commit 9a38741 into main Apr 18, 2022
@PureWeen PureWeen deleted the fix_swapping_titleviews branch April 18, 2022 21:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.2 Look for this fix in 6.0.300-rc.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@drasticactions drasticactions drasticactions approved these changes

Assignees
No one assigned
Labels
fixed-in-6.0.300-rc.2 Look for this fix in 6.0.300-rc.2!
Projects
None yet
Milestone
6.0.300-rc.2
4 participants
@PureWeen @drasticactions @Redth @samhouts