[Windows] Not render shadows on without a ShadowColor #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
jsuarezruiz
commented
Apr 18, 2022
| @@ -8,7 +8,7 @@ public class Shadow : Element, IShadow | |||
|
|
|||
| public static readonly BindableProperty OpacityProperty = BindableProperty.Create(nameof(Opacity), typeof(float), typeof(Shadow), 1f); | |||
|
|
|||
| public static readonly BindableProperty BrushProperty = BindableProperty.Create(nameof(Brush), typeof(Brush), typeof(Shadow), null); | |||
| public static readonly BindableProperty BrushProperty = BindableProperty.Create(nameof(Brush), typeof(Brush), typeof(Shadow), Brush.Black); | |||
There was a problem hiding this comment.
Default Shadow Brush becomes a black SolidColorBrush.
jsuarezruiz
commented
Apr 18, 2022
| @@ -164,7 +164,7 @@ void DisposeShadow() | |||
|
|
|||
| async Task CreateShadowAsync() | |||
| { | |||
| if (Child == null || Shadow == null) | |||
| if (Child == null || Shadow == null || Shadow.Paint == null) | |||
There was a problem hiding this comment.
Avoid render shadows on Windows if the ShadowColor property is null.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jsuarezruiz
commented
Apr 25, 2022
| float opacity = 0; | ||
| var shadowColor = Graphics.Colors.Transparent; | ||
| var offset = new Graphics.Point(1, 1); | ||
| float blurRadius = 10f; |
There was a problem hiding this comment.
Default Values.
Redth
approved these changes
Apr 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR is related with the issue 5820, but actually, that issue had two different issues. On the one hand, the Shadow applied to the Border was not rendered on Android and on the other hand, the shape is not quite correct.
What happens:
This PR adds the following changes:
<Shadow />with the default properties renders a black shadow around the View on all platforms.Fixes ##5820