WinForms/WPF/MAUI-Windows API review changes #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
approved these changes
Apr 12, 2022
Eilon
reviewed
Apr 12, 2022
| namespace Microsoft.AspNetCore.Components.WebView.WindowsForms | ||
| { | ||
| /// <summary> | ||
| /// A builder for WindowsForms Blazor WebViews. |
There was a problem hiding this comment.
Suggested change
| /// A builder for WindowsForms Blazor WebViews. | |
| /// A builder for Windows Forms Blazor WebViews. |
There was a problem hiding this comment.
Good point. However your approval triggered automerge! Followed up at #6001
There was a problem hiding this comment.
Understood, definitely my fault. I noticed it right as I was clicking Approve 😁
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5906
Fixes #5909
Fixes #5910
The approach to nullability I've taken is similar to what we do in ASP.NET Core. That is, in most cases we're honest about nullability, but in cases where for intended usage scenarios a certain thing is not going to be null, it's typed as not-null (example: things that always get initialized as not-null by the framework before application code is expected to run).