-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlazorWebView API review changes: Shared sources #5982
BlazorWebView API review changes: Shared sources #5982
Conversation
src/BlazorWebView/src/SharedSource/BlazorWebViewServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/BlazorWebView/src/SharedSource/BlazorWebViewServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/BlazorWebView/src/SharedSource/BlazorWebViewServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @MackinnonBuck!
I'd personally prefer it if we still changed https://github.com/dotnet/maui/pull/5982/files#r848252057 but approving now to ensure this can be merged whenever you are ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
Description of Change
Addresses changes to the BlazorWebView API for shared sources.
It should be noted that there are a few items in the linked issue that this PR does not address:
Addressed in #5984.
AFAICT, there isn't a convenient way to create a
ParameterView
from anIReadOnlyDictionary<string, object?>
(theParameterView.FromDictionary()
method only accepts anIDictionary<string, object?>
).So, it doesn't seem we would be able to make this change without either copying to a new dictionary or making changes to
ParameterView
in dotnet/aspnetcore. The former is undesirable and the latter might not be feasible this late in the release cycle.We do react if the collection is modified, so no change is required here.
Issues Fixed
Fixes #5905