Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backbutton visibility when popping #5893

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Apr 7, 2022

Description of Change

Shell toolbar handling was converted over to use all the same logic as the NavigationPage. Unfortunately there are still a couple parts like the drawer button which can't be handled by the NavigationPage logic. This code triggers that special shell code after the user has navigated to ensure the toolbar is setup correctly

@PureWeen PureWeen added this to the 6.0.300-rc.2 milestone Apr 7, 2022
@PureWeen PureWeen enabled auto-merge (squash) April 7, 2022 20:06
@jsuarezruiz jsuarezruiz added area-controls-shell Shell Navigation, Routes, Tabs, Flyout t/bug Something isn't working labels Apr 11, 2022
@PureWeen PureWeen merged commit faea3b8 into main Apr 11, 2022
@PureWeen PureWeen deleted the fix_shell_backbutton_visibility branch April 11, 2022 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.2 Look for this fix in 6.0.300-rc.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.300-rc.2 Look for this fix in 6.0.300-rc.2! t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants