[iOS] Implement iOS Platform Specifics #5879
Conversation
|
|
||
| namespace Microsoft.Maui.Controls.Platform | ||
| { | ||
| public static class TextExtensions | ||
| { | ||
| public static void UpdateCursorColor(this UITextField textField, Entry entry) |
There was a problem hiding this comment.
Entry Cursor Color on iOS https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/ios/entry-cursor-color
|
|
||
| namespace Microsoft.Maui.Controls.Platform | ||
| { | ||
| public static class SearchBarExtensions | ||
| { | ||
| public static void UpdateSearchBarStyle(this UISearchBar uiSearchBar, SearchBar searchBar) |
There was a problem hiding this comment.
SearchBar style on iOS https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/ios/searchbar-style
| { | ||
| public partial class DatePicker | ||
| { | ||
| public static void MapUpdateMode(DatePickerHandler handler, DatePicker datePicker) |
There was a problem hiding this comment.
DatePicker item selection on iOS https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/ios/datepicker-selection
| { | ||
| public partial class Picker | ||
| { | ||
| public static void MapUpdateMode(PickerHandler handler, Picker picker) |
There was a problem hiding this comment.
Picker Item Selection on iOS https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/ios/picker-selection
| { | ||
| public partial class TimePicker | ||
| { | ||
| public static void MapUpdateMode(TimePickerHandler handler, TimePicker timePicker) |
There was a problem hiding this comment.
TimePicker item selection on iOS https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/ios/timepicker-selection
| Platform.TextExtensions.UpdateCursorColor(handler.PlatformView, entry); | ||
| } | ||
|
|
||
| public static void MapAdjustsFontSizeToFitWidth(EntryHandler handler, Entry entry) |
There was a problem hiding this comment.
Entry Font Size on iOS https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/ios/entry-font-size
| @@ -2,6 +2,16 @@ | |||
| { | |||
| public partial class Entry | |||
| { | |||
| public static void MapCursorColor(EntryHandler handler, Entry entry) | |||
There was a problem hiding this comment.
Entry Cursor Color on iOS https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/ios/entry-cursor-color
Eilon
added
the
legacy-area-controls
jsuarezruiz
changed the title
| @@ -13,6 +13,8 @@ protected override UIDatePicker CreatePlatformView() | |||
| ; | |||
| } | |||
|
|
|||
| internal bool UpdateImmediately { get; set; } | |||
There was a problem hiding this comment.
Should this be true by default since that is what the code before this PR appears to be doing? Maybe we don't want this actually and we should always set the value?
And then whatever we do here we need to also do for the other pickers on both platforms.
There was a problem hiding this comment.
Yeah makes sense since there's no "Done" button for this on catalyst
There was a problem hiding this comment.
What about the other mac catalyst platforms? Is this not needed on iOS?
There was a problem hiding this comment.
I mean you set the value to true in 1 file, but there are 3 pickers each with 2 files mac/ios.
There was a problem hiding this comment.
Didn't test it all yet but here some that didn't work for me: can you take a look @jsuarezruiz ?
Blur - doesn’t work
Picker - doesn’t work
SafeArea - doesn’t work
Slider Update on tap - doesn’t work
Hide Status bar - doesn’t work
TimePicker - doesn’t work
|
Can we also add this to the gallery, we might need to inject the ICommand to go back |
|
Also the PR descriptions says Windows, but it's iOS |
|
Ok finished review everything, here's what works and doesn't work.. |
Description of Change
Implement iOS Platform Specifics.
Fixes (partially) #5856