-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Essentials Maps TryOpen #5834
Conversation
@mattleibow is there a specific reason that not all overloads are surfaced in the |
Do we want to have XML API docs for this? Do we generate that? How does it work? |
Mostly because a lot are the same api, just different parameters. The overload are echoed via extension methods in the shared code. |
Not yet for the interfaces. We need to. And the extension methods |
does this only check if some map is installed to be opened or should it open maps too? |
Description of Change
Port from this Xamarin.Essentials PR here: xamarin/Essentials#1665
Note, this feature will not be merged in Essentials, but it was approved at the time, so I thought it might be a nice addition for .NET MAUI
API Changes
Added:
Task<bool> TryOpenAsync(Location location)
Task<bool> TryOpenAsync(Location location, MapLaunchOptions options)
Task<bool> TryOpenAsync(double latitude, double longitude)
Task<bool> TryOpenAsync(double latitude, double longitude, MapLaunchOptions options)
Task<bool> TryOpenAsync(Placemark placemark)
Task<bool> TryOpenAsync(Placemark placemark, MapLaunchOptions options)
Issues Fixed
Original Xamarin.Essentials issue: xamarin/Essentials#1289