Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BuildTools as it is part of VS #5705

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Mar 31, 2022

Description of Change

Remove the BuildTools from the manifest because this is not a runtime package and also it already exists in VS.

Since it is not a runtime package, we can't really include it in the way we need:

VALIDATEMANIFEST : warning : PackageDependenciesAreSatisfiedWarnings failed : Dependencies for chip='', language='' : The dependent package of 'maui.windows,version=#NUM#.#NUM#.#NUM#.#NUM#' cannot be found: Microsoft.Windows.SDK.BuildTools.#NUM#.#NUM#.#NUM#.#NUM#,version=#NUM#.#NUM#.#NUM#.#NUM#. : [manifest=VisualStudio/#NUM#.#NUM#.#NUM#+#NUM#.#NUM#.main]

Also removing the WASDK from the inserting because of missing symbols.

@mattleibow mattleibow added this to the 6.0.300-rc.1 milestone Mar 31, 2022
@mattleibow mattleibow changed the title Dev/remove buildtools Remove BuildTools as it is part of VS Mar 31, 2022
@mattleibow mattleibow self-assigned this Mar 31, 2022
Copy link
Member

@pjcollins pjcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the sign check issues we're also seeing, I think we will want to remove both this and the Microsoft.WindowsAppSDK package from the workload for now.

@mattleibow
Copy link
Member Author

The failing files are:

  • bin\10.0.22000.0\x64\deployutil.exe
  • bin\10.0.22000.0\arm64\deployutil.exe
  • bin\10.0.22000.0\arm\deployutil.exe
  • bin\10.0.22000.0\x86\deployutil.exe

Is it possible to ignore this folder as it is a tool used at build time?

@mattleibow mattleibow requested review from pjcollins and Redth March 31, 2022 15:36
@pjcollins
Copy link
Member

We could potentially get an exception for deployutil.exe in Microsoft.Windows.SDK.BuildTools, but there are also 220 unsigned files in the Microsoft.WindowsAppSDK package that would also need to be addressed. I think the signing issues would be a harder sell, and we'll probably need to engage with the team producing these packages to figure out next steps.

@mattleibow mattleibow merged commit a21a357 into release/6.0.3xx-rc1 Mar 31, 2022
@mattleibow mattleibow deleted the dev/remove-buildtools branch March 31, 2022 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants