Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android reduce singleline usage #5690

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Android reduce singleline usage #5690

merged 2 commits into from
Mar 31, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Mar 30, 2022

Description of Change

Setting the deprecated singleLine property is unnecessary for most LineBreakMode situations, and it breaks some of our ButtonHandler tests.

These changes reduce singleLine usage only to the necessary API levels and situations.

@rmarinho
Copy link
Member

This fixes the failing tests.. right?

Also I see this in the debug window

[StaticLayout] maxLineHeight should not be -1.  maxLines:1 lineCount:1
[StaticLayout] maxLineHeight should not be -1.  maxLines:1 lineCount:1
[StaticLayout] maxLineHeight should not be -1.  maxLines:1 lineCount:1
[StaticLayout] maxLineHeight should not be -1.  maxLines:1 lineCount:1

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rmarinho rmarinho merged commit 85f50e5 into main Mar 31, 2022
@rmarinho rmarinho deleted the android-singleline branch March 31, 2022 12:55
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

Assignees
No one assigned
Labels
area-controls-editor Editor area-controls-entry Entry fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! platform/android 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hartez @rmarinho @jsuarezruiz @Eilon @samhouts