Use fallbacks for font sizes when getting font from Span on Android #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spans have a 0 font size by default, and on Android this means the font is literally 0 in size and won't appear. If you had an attribute set other than None, it was hitting a code path here to get the font from the span and used the 0 size incorrectly. This should ensure the font size falls back to first the Formatted string or target control the font is to be used in, and then to the system default font size from the FontManager if necessary so that the span shows up. This fixes the android part of #5576
Redth
added
the
legacy-area-controls
mattleibow
approved these changes
Apr 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spans have a 0 font size by default, and on Android this means the font is literally 0 in size and won't appear. If you had an attribute set other than None, it was hitting a code path here to get the font from the span and used the 0 size incorrectly.
This should ensure the font size falls back to first the Formatted string or target control the font is to be used in, and then to the system default font size from the FontManager if necessary so that the span shows up.
This fixes the android part of #5576
Description of Change
Issues Fixed
Fixes #