Try check the current thread first #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redth
reviewed
Mar 30, 2022
|
|
||
| if (dispatcher == null) | ||
| throw new InvalidOperationException("Unable to find main thread."); | ||
|
|
||
| if (!dispatcher.TryEnqueue(DispatcherQueuePriority.Normal, () => action())) | ||
| throw new InvalidOperationException("Unable to queue on the main thread."); | ||
| } | ||
|
|
||
| static DispatcherQueue? TryGetDispatcherQueue() => | ||
| DispatcherQueue.GetForCurrentThread() ?? |
There was a problem hiding this comment.
GetForCurrentThread - this is get for current UI/Main thread? is that assumed?
There was a problem hiding this comment.
This gets for the current thread. So if you are in the background, it will return null. However, at startup, you are on the thread with a dispatcher. But yeah, no way to get the "main thread" as any thread can be a "main thread" if it has a UI context set up.
Redth
approved these changes
Mar 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #5671