Ensure GroupValueChangedMessage is received #5646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There are three fixes in this change.
The message registration type is changed from
ILayout
toElement
. This is because_layout
inRadioButtonGroupController
is actually an instance ofElement
.The checking for
Value != args.Value
is changed to!Value.Equals(args.Value)
. This is becauseValue
andargs.Value
can come from different sources and object reference equality often doesn't work.In case the
SelectedValue
of the radio group is changed before the radio buttons are added to the group, the radio button missed the event to set its default value and won't set itsIsChecked
state. Therefore we need to make sure when a radio button is added to the group, it sets itsIsChecked
state to the correct value.Issues Fixed
Fixes #5645
@softlion