Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Size and fix modal touch events #5644

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Modal Size and fix modal touch events #5644

merged 2 commits into from
Apr 1, 2022

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Mar 29, 2022 •
edited
Loading

Description of Change

  • When the user touches anywhere on the Modal that's not an input control we need to set the touch as handled so it doesn't pass through to the view underneath
  • Measure the Modal window to match the same position/size as the underlying view. This means we need to take into account the statusbar and the navigationbar

Issues Fixed

Fixes #5627
Fixes #4961

Accessibility

Validate that accessibility/keyboard navigation still works as expected when you push a modal page. If this is all working correctly we can close #3127

@PureWeen PureWeen added this to the 6.0.300-rc.2 milestone Mar 29, 2022
@PureWeen PureWeen requested a review from rachelkang March 29, 2022 17:21
rachelkang
rachelkang approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PureWeen
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PureWeen PureWeen requested a review from Redth April 1, 2022 15:34
@PureWeen PureWeen enabled auto-merge (squash) April 1, 2022 15:35
@PureWeen PureWeen merged commit 4664484 into main Apr 1, 2022
@PureWeen PureWeen deleted the modal_fixes branch April 1, 2022 16:37
@AmrAlSayed0
Copy link
Contributor

There is a chance that the status bar would be disabled/hidden (like it is in our apps) or the orientation of the modal page is landscape (I don't know if that switches the l, t, r, b values)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.300-rc.2 Look for this fix in 6.0.300-rc.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@rachelkang rachelkang rachelkang approved these changes

Assignees
No one assigned
Labels
area-controls-modal fixed-in-6.0.300-rc.2 Look for this fix in 6.0.300-rc.2!
Projects
None yet
Milestone
6.0.300-rc.2
7 participants
@PureWeen @AmrAlSayed0 @Redth @jsuarezruiz @rachelkang @jfversluis @samhouts