[android] update to the latest AndroidX packages #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#5305 Fixes: dotnet/android-libraries#509 Update to the latest AndroidX packages, so we also use the latest Xamarin.Google.Guava.ListenableFuture This currently has build failures: src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(145,41): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(188,48): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) src\Core\src\Platform\Android\Navigation\StackNavigationManager.cs(245,51): error CS1061: 'NavController' does not contain a definition for 'BackStack' and no accessible extension method 'BackStack' accepting a first argument of type 'NavController' could be found (are you missing a using directive or an assembly reference?) Looking at: ~\.nuget\packages\xamarin.androidx.navigation.runtime\2.4.1\lib\net6.0-android31.0\Xamarin.AndroidX.Navigation.Runtime.dll I can't find: [Register("androidx/navigation/NavController", DoNotGenerateAcw = true)] public class NavController : Object { public unsafe virtual IDeque BackStack { [Register("getBackStack", "()Ljava/util/Deque;", "GetGetBackStackHandler")] get; But it's not documented here either: https://developer.android.com/reference/androidx/navigation/NavController
|
It does appear that it has been removed in 2.4+. navigation-runtime-2.3.5.aar: navigation-runtime-2.4.1.aar: I think their: essentially means "this is not public API". We likely should not be binding stuff marked this way, but it's not something our tools have support for. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jonathanpeppers
commented
Mar 28, 2022
Comment on lines
-145
to
+146
| var iterator = NavHost.NavController.BackStack.Iterator(); | ||
| var iterator = NavHost.NavController.BackQueue.Iterator(); |
|
|
I'm having trouble reproducing this problem locally... I get no warnings or errors with Trying |
|
Ok, I see the same test failures on other PRs. I had retried them a few times. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #5305
Fixes: dotnet/android-libraries#509
Update to the latest AndroidX packages, so we also use the latest
Xamarin.Google.Guava.ListenableFuture
This currently has build failures:
Looking at:
I can't find:
But it's not documented here either:
https://developer.android.com/reference/androidx/navigation/NavController