[X] compile gridlength and row|defcollection #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| get { return new GridLength(1, GridUnitType.Auto); } | ||
| } | ||
| public static readonly GridLength Auto = new GridLength(1, GridUnitType.Auto); |
There was a problem hiding this comment.
Actual breaking change, from static property to static field, require recompile
There was a problem hiding this comment.
If we didn't want to make a breaking change here, we could accomplish the same thing by using a property with an initializer:
public static GridLength Auto { get; } = new GridLength(1, GridUnitType.Auto);
|
/cc @eerhardt |
|
Seems ok to me, mostly additive and recompiles but not renames of existing 👍 |
eerhardt
reviewed
Mar 22, 2022
src/Controls/tests/Xaml.UnitTests/DefinitionCollectionTests.xaml.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Build.Tasks/CompiledConverters/ColumnDefinitionCollectionTypeConverter.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Build.Tasks/CompiledConverters/ColumnDefinitionCollectionTypeConverter.cs
Show resolved
Hide resolved
Co-authored-by: Eric Erhardt <[email protected]>
…ml.cs Co-authored-by: Eric Erhardt <[email protected]>
StephaneDelcroix
force-pushed
the
fix_5430
branch
from
69bd31b to
1283d58
Compare
StephaneDelcroix
force-pushed
the
fix_5430
branch
from
1283d58 to
5cacb5e
Compare
Eilon
added
the
area-layout
eerhardt
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
LGTM.
You may want to consider #5489 (comment). Typically we use properties instead of fields in public APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #