Use Factory methods in DependencyInjection #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using factory methods and directly invoking the constructors instead of letting DI use reflection to find the constructor. In local testing this appeared to shave off ~7ms from startup of a dotnet new maui app.
- Add TryAddSingleton`2 to the banned API list
jonathanpeppers
approved these changes
Mar 15, 2022
samhouts
added
area-architecture
Eilon
added
the
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using factory methods and directly invoking the constructors instead of letting DI use reflection to find the constructor.
In local testing this appeared to shave off ~7ms from startup of a dotnet new maui app.
With changes:
Average(ms): 571
Average(ms): 579.9
Average(ms): 572.6
Main:
Average(ms): 584.5
Average(ms): 586.9
Average(ms): 579.6