Fix Shapes Aspect property #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
the
area-drawing
|
|
Redth
approved these changes
Mar 22, 2022
Added changes to correctly clipping on Android. |
Redth
approved these changes
Mar 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix Shapes Aspect property.
Before
After
NOTE: There are pending issues related to size, mainly when not set HeightRequest and WidthRequest (get the bounds by flattening the path). Although we can split it into different PRs, I am going to mark this PR for now as a Draft in order to try to unify all the fixes related to size and aspect in the same PR.
Issues Fixed
Related with #5094