[Windows] Fixes related with Clipping #5224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
platform/windows 🪟
area-drawing
jsuarezruiz
commented
Mar 11, 2022
| @@ -55,6 +55,7 @@ internal set | |||
|
|
|||
| public void Dispose() | |||
| { | |||
| DisposeClip(); | |||
There was a problem hiding this comment.
Allow dynamically removing an existing Clipping (Set Clip = null).
jsuarezruiz
commented
Mar 11, 2022
| @@ -109,6 +108,8 @@ void DrawFillPath(ICanvas canvas, RectF dirtyRect, PathF path) | |||
|
|
|||
| canvas.SaveState(); | |||
|
|
|||
| ClipPath(canvas, path); | |||
There was a problem hiding this comment.
Fix CanvasDrawingSession exception.
mattleibow
approved these changes
Mar 16, 2022
|
Hi @jsuarezruiz , I have updated the RC 1 update with the ClipRadiusGallery sample of .NET MAUI sample gallery. Still the corner radius is not set correctly. Only the top left works.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes related with Clipping on Windows. Fixed exception
"After calling CanvasDrawingSession.CreateLayer, you must close the resulting CanvasActiveLayer before ending the CanvasDrawingSession"and allow dynamically removing a Clipping.To test the changes launch the .NET MAUI Gallery, navigate to the Shapes page and use the Clipping samples.
Issues Fixed
Fixes #4250