Remove Routing with a Fully Qualified Type name #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior is not trim-compatible, since it just a random string "route name" and calls Type.GetType with it, and then Activator.CreateInstance. The trimmer might have removed the whole type, or even the constructor on the Type. This would cause a trimmed application to behave differently than an untrimmed application. I do not know of anyone who relies on this behavior, and there are no tests for it. So removing it seems like the best path forward. Contributes to dotnet#1962
eerhardt
requested review from
hartez,
jonathanpeppers,
mattleibow,
rmarinho and
PureWeen
Redth
approved these changes
Mar 4, 2022
jonathanpeppers
approved these changes
Mar 4, 2022
Comment on lines
-147
to
-164
| // okay maybe its a type, we'll try that just to be nice to the user | ||
| var type = Type.GetType(route); |
There was a problem hiding this comment.
I don't think anyone would use a route like:
app://home/MyAssemblyName, MyNamespace.MyPageName
The space, comma, and dot would make this a very weird URL.
|
Looks like this needs to delete a test, though: |
mattleibow
approved these changes
Mar 4, 2022
|
Right, the build is failing because of this test. |
PureWeen
approved these changes
Mar 4, 2022
PureWeen
requested changes
Mar 4, 2022
| @@ -623,57 +623,6 @@ public async Task RouteWithGlobalPageRoute() | |||
| Assert.AreEqual("//animals/domestic/cats/catdetails", shell.CurrentState.Location.ToString()); | |||
| } | |||
|
|
|||
| [TestCase(typeof(PageWithDependency), typeof(PageWithDependency))] | |||
There was a problem hiding this comment.
I don't think we want to fully remove this test. Let me fix
PureWeen
approved these changes
Mar 4, 2022
samhouts
added
area-controls-shell
Eilon
added
the
area-publishing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is not trim-compatible, since it just a random string "route name" and calls Type.GetType with it, and then Activator.CreateInstance. The trimmer might have removed the whole type, or even the constructor on the Type. This would cause a trimmed application to behave differently than an untrimmed application.
I do not know of anyone who relies on this behavior, and there are no tests for it. So removing it seems like the best path forward.
Contributes to #1962