Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IBorder on Windows #5008

Merged
merged 5 commits into from
Mar 3, 2022
Merged

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Mar 2, 2022

Description of Change

Implement IBorder on Windows. Need to validate this changes with Comet.

NOTE: It is a Draft because it is still in progress.

@Clancey Could you let me know when you update Comet and be able to test these changes?

@jsuarezruiz jsuarezruiz added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Mar 2, 2022
@Redth Redth marked this pull request as ready for review March 3, 2022 15:22
@Redth
Copy link
Member

Redth commented Mar 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Redth Redth changed the base branch from main to release/6.0.2xx-preview14 March 3, 2022 15:52
@Redth Redth merged commit c97d44d into release/6.0.2xx-preview14 Mar 3, 2022
@Redth Redth deleted the iborder-windows branch March 3, 2022 17:10
Redth added a commit that referenced this pull request Mar 3, 2022
* Implement IBorder on Windows (#5008)

* Implement IBorder on Windows

* Fix rectangles

Co-authored-by: redth <[email protected]>

* Remove all usage of Device throughout the repo (#4982)

Co-authored-by: Javier Suárez <[email protected]>
Co-authored-by: Matthew Leibowitz <[email protected]>
Redth added a commit that referenced this pull request Mar 4, 2022
* Implement IBorder on Windows (#5008)

* Implement IBorder on Windows

* Fix rectangles

Co-authored-by: redth <[email protected]>

* Remove all usage of Device throughout the repo (#4982)

* Remove unsupported targets in Device class (#4491)

* Remove unsupported targets in Device class

* Fixed broken tests

* Deprecate UWP target

* Allow to use UWP target on XAML

* Fix build errors

* comments

* UWP == WinUI

* Fix Build errors

* Added more tests

* fix

* vbnm

* More fixes

* things

Co-authored-by: Matthew Leibowitz <[email protected]>

Co-authored-by: Javier Suárez <[email protected]>
Co-authored-by: Matthew Leibowitz <[email protected]>
Redth added a commit that referenced this pull request Mar 4, 2022
* Implement IBorder on Windows (#5008)

* Implement IBorder on Windows

* Fix rectangles

Co-authored-by: redth <[email protected]>

* Remove all usage of Device throughout the repo (#4982)

* Remove unsupported targets in Device class (#4491)

* Remove unsupported targets in Device class

* Fixed broken tests

* Deprecate UWP target

* Allow to use UWP target on XAML

* Fix build errors

* comments

* UWP == WinUI

* Fix Build errors

* Added more tests

* fix

* vbnm

* More fixes

* things

Co-authored-by: Matthew Leibowitz <[email protected]>

* [ci] Remove image override (#5053)

* [ci] Remove image override

* [ci] Don't provisioning windows

Co-authored-by: Javier Suárez <[email protected]>
Co-authored-by: Matthew Leibowitz <[email protected]>
Co-authored-by: Rui Marinho <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants