-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IBorder on Windows #5008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redth
approved these changes
Mar 2, 2022
Clancey
approved these changes
Mar 2, 2022
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Redth
added a commit
that referenced
this pull request
Mar 3, 2022
* Implement IBorder on Windows (#5008) * Implement IBorder on Windows * Fix rectangles Co-authored-by: redth <[email protected]> * Remove all usage of Device throughout the repo (#4982) Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Matthew Leibowitz <[email protected]>
Redth
added a commit
that referenced
this pull request
Mar 4, 2022
* Implement IBorder on Windows (#5008) * Implement IBorder on Windows * Fix rectangles Co-authored-by: redth <[email protected]> * Remove all usage of Device throughout the repo (#4982) * Remove unsupported targets in Device class (#4491) * Remove unsupported targets in Device class * Fixed broken tests * Deprecate UWP target * Allow to use UWP target on XAML * Fix build errors * comments * UWP == WinUI * Fix Build errors * Added more tests * fix * vbnm * More fixes * things Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Matthew Leibowitz <[email protected]>
Redth
added a commit
that referenced
this pull request
Mar 4, 2022
* Implement IBorder on Windows (#5008) * Implement IBorder on Windows * Fix rectangles Co-authored-by: redth <[email protected]> * Remove all usage of Device throughout the repo (#4982) * Remove unsupported targets in Device class (#4491) * Remove unsupported targets in Device class * Fixed broken tests * Deprecate UWP target * Allow to use UWP target on XAML * Fix build errors * comments * UWP == WinUI * Fix Build errors * Added more tests * fix * vbnm * More fixes * things Co-authored-by: Matthew Leibowitz <[email protected]> * [ci] Remove image override (#5053) * [ci] Remove image override * [ci] Don't provisioning windows Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: Rui Marinho <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-drawing
Shapes, Borders, Shadows, Graphics, BoxView, custom drawing
fixed-in-6.0.200-preview.14.2
Look for this fix in 6.0.200-preview.14.2!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implement
IBorder
on Windows. Need to validate this changes with Comet.NOTE: It is a Draft because it is still in progress.
@Clancey Could you let me know when you update Comet and be able to test these changes?