Don't set the text on android if value matches #4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
approved these changes
Mar 1, 2022
PureWeen
changed the title
samhouts
added
area-controls-editor
ghost
added
the
legacy-area-controls
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On android if you set the text to the same value it causes the cursor to reset to the initial position. We fixed this once in
Corebut it broke again with theTextTransformchangesTextTransformis a little bit trickier to manage because we're modifying the text after it's been set on the platform control. This PR attempts to only restore the cursor for cases where theTextTransformis modifying the text. If the user is modifying the text then we just want it to fall back to whatever the default platform behavior is.