Remove Application.Properties implementation #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Application.Properties and SavePropertiesAsync APIs bring in a dependency on `DataContractSerializer` in a default application. This, in turn, brings in a lot of the System.Xml code by default. Since these APIs are already marked as obsolete, and the recommendation is to use the corresponding Essentials APIs, remove the implementation of these APIs and instead throw an exception. This will allow for `DataContractSerializer` to be removed in a default app. From my local testing this removes 855 KB of IL in a `dotnet new maui` Android application. Before: 10.9 MB (11,431,696 bytes) After: 10.0 MB (10,556,176 bytes) And it cuts 1 MB out of a published `dotnet new maui` iOS application .ipa size. Before: 18.0 MB (18,918,198 bytes) After: 17.0 MB (17,850,723 bytes) Fix dotnet#4864
mattleibow
approved these changes
Mar 1, 2022
|
Probably old test code that needs deleting... |
- Converted tests to Essentials.Preferences where applicable. - Removed tests that were explicitly for testing Application.Properties.
|
@mattleibow @PureWeen - are you OK with the test changes I needed to make? If so, I believe this is ready now. |
mattleibow
approved these changes
Mar 1, 2022
|
How can i migrate the data saved in Application.Properties to Microsoft.Maui.Storage.Preferences Since Application.Properties Application.Properties was removed? |
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Application.Properties and SavePropertiesAsync APIs bring in a dependency
on
DataContractSerializerin a default application. This, in turn, bringsin a lot of the System.Xml code by default.
Since these APIs are already marked as obsolete, and the recommendation is to use
the corresponding Essentials APIs, remove the implementation of these APIs and
instead throw an exception. This will allow for
DataContractSerializerto beremoved in a default app.
From my local testing this removes 855 KB of IL in a
dotnet new mauiAndroidapplication.
Before: 10.9 MB (11,431,696 bytes)
After: 10.0 MB (10,556,176 bytes)
And it cuts 1 MB out of a published
dotnet new mauiiOS application .ipa size.Before: 18.0 MB (18,918,198 bytes)
After: 17.0 MB (17,850,723 bytes)
Fix #4864