[android] add projects to record AOT profiles #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
commented
Feb 23, 2022
|
In-tree tests are failing... because I moved the |
jonathanpeppers
force-pushed
the
ProfiledAOT
branch
from
1c0de5d to
8da1947
Compare
eerhardt
reviewed
Feb 24, 2022
jonathanpeppers
commented
Feb 24, 2022
Context: https://github.com/jonathanpeppers/Mono.Profiler.Android#usage-of-the-aot-profiler Adds projects and instructions for creating AOT profiles for Android. Additionally, add a new profile for `maui-blazor` to be used when `$(UsingMicrosoftNETSdkRazor)` is `true`. `CommonMethods.cs` has various APIs that we want to include in the built-in AOT profile. Right now, it most importantly includes usage of `HttpClient` and `System.Threading.Tasks`. `maui.aotprofile.txt` is an alphabetical list of methods in the profile. We can track changes to this file over time. ~~ Results ~~ `dotnet new maui` on a Pixel 5: 02-23 09:48:40.822 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +470ms 02-23 09:48:42.056 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +485ms 02-23 09:48:43.262 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +465ms 02-23 09:48:44.438 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +471ms 02-23 09:48:45.667 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +473ms 02-23 09:48:46.909 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +458ms 02-23 09:48:48.100 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +462ms 02-23 09:48:49.312 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +463ms 02-23 09:48:50.538 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +461ms 02-23 09:48:51.719 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +465ms Average(ms): 467.3 Std Err(ms): 2.47229088543849 Std Dev(ms): 7.81807023646003 Same project using MAUI Preview 13 was `Average(ms): 490.9`. `dotnet new maui-blazor`: 02-23 09:51:23.245 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +570ms 02-23 09:51:24.480 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +595ms 02-23 09:51:25.656 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +574ms 02-23 09:51:26.870 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +577ms 02-23 09:51:28.078 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +584ms 02-23 09:51:29.243 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +556ms 02-23 09:51:30.457 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +570ms 02-23 09:51:31.699 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +596ms 02-23 09:51:32.896 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +578ms 02-23 09:51:34.117 1802 1962 I ActivityTaskManager: Displayed com.companyname.foo/crc64808a40cc7e533249.MainActivity: +578ms Average(ms): 577.8 Std Err(ms): 3.76769897358528 Std Dev(ms): 11.9145102944081 Same project using MAUI Preview 13 was `Average(ms): 664.0`.
jonathanpeppers
force-pushed
the
ProfiledAOT
branch
from
8da1947 to
573706a
Compare
jonathanpeppers
commented
Feb 24, 2022
Comment on lines
+12
to
+14
| <Exec Command=""$(DotNetToolPath)" new $(App) -o $(Intermediate)" EnvironmentVariables="$(EnvVars)" /> | ||
| <!-- MainPage.xaml.cs uses CommonMethod.cs --> | ||
| <Copy SourceFiles="src/MainPage-$(App).cs" DestinationFiles="$(Intermediate)MainPage.xaml.cs" /> |
There was a problem hiding this comment.
This now invokes the template and copies one file over top. So a lot less code now.
jonathanpeppers
commented
Feb 24, 2022
src/ProfiledAot/README.md
Outdated
Comment on lines
14
to
15
| $ ./bin/dotnet/dotnet build src/ProfiledAot/build.proj -p:App=maui | ||
| $ ./bin/dotnet/dotnet build src/ProfiledAot/build.proj -p:App=maui-blazor |
There was a problem hiding this comment.
Instructions have changed now as well.
eerhardt
reviewed
Feb 25, 2022
eerhardt
reviewed
Feb 25, 2022
eerhardt
approved these changes
Feb 25, 2022
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/jonathanpeppers/Mono.Profiler.Android#usage-of-the-aot-profiler
Adds projects and instructions for creating AOT profiles for Android.
Additionally, add a new profile for
maui-blazorto be used when$(UsingMicrosoftNETSdkRazor)istrue.CommonMethods.cshas various APIs that we want to include in thebuilt-in AOT profile. Right now, it most importantly includes usage of
HttpClientandSystem.Threading.Tasks.maui.aotprofile.txtis an alphabetical list of methods in theprofile. We can track changes to this file over time.
Results
dotnet new mauion a Pixel 5:Same project using MAUI Preview 13 was
Average(ms): 490.9.dotnet new maui-blazor:Same project using MAUI Preview 13 was
Average(ms): 664.0.PR Checklist
Does this PR touch anything that might affect accessibility?
No