-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming public APIs Native --> Platform #4599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better if api rename will be implemented in net 7 and not delay other projects that are targeting net 6... |
jsuarezruiz
reviewed
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase main to fix the conflicts?. Thnx!
de567f1
to
dd0aaee
Compare
# Conflicts: # src/Compatibility/Core/src/iOS/Renderers/TableViewRenderer.cs # src/Compatibility/Maps/src/iOS/MapRenderer.cs # src/Core/src/Handlers/Picker/PickerHandler.iOS.cs # src/Core/src/Platform/iOS/ElementExtensions.cs
PureWeen
approved these changes
Feb 16, 2022
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-architecture
Issues with code structure, SDK structure, implementation details
fixed-in-6.0.200-preview.14.2
Look for this fix in 6.0.200-preview.14.2!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Renames all public APIs with "Native" to "Platform"
(and a bit more probably)
Implements #4451
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.