Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming public APIs Native --> Platform #4599

Merged
merged 66 commits into from
Feb 16, 2022
Merged

Renaming public APIs Native --> Platform #4599

merged 66 commits into from
Feb 16, 2022

Conversation

rachelkang
Copy link
Member

Description of Change

Renames all public APIs with "Native" to "Platform"
(and a bit more probably)

Implements #4451

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@cesarchefinho
Copy link

Better if api rename will be implemented in net 7 and not delay other projects that are targeting net 6...

@Eilon Eilon added the area-architecture Issues with code structure, SDK structure, implementation details label Feb 11, 2022
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase main to fix the conflicts?. Thnx!

# Conflicts:
#	src/Compatibility/Core/src/iOS/Renderers/TableViewRenderer.cs
#	src/Compatibility/Maps/src/iOS/MapRenderer.cs
#	src/Core/src/Handlers/Picker/PickerHandler.iOS.cs
#	src/Core/src/Platform/iOS/ElementExtensions.cs
@PureWeen PureWeen removed the request for review from a team February 16, 2022 14:24
@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) February 16, 2022 14:36
@PureWeen PureWeen disabled auto-merge February 16, 2022 15:01
@PureWeen PureWeen merged commit 3717ce0 into main Feb 16, 2022
@PureWeen PureWeen deleted the native-to-platform branch February 16, 2022 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-architecture Issues with code structure, SDK structure, implementation details fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants