Skip some mappings when using formatted text #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS, we have more mappings registered and they fire _after_ the mapper that fires for FormattedText. Since these other ones also set the AttributedString on the platform control, they override what was in FormattedText. This changes it so they do not, and FormattedText always takes priority.
mattleibow
approved these changes
Jan 18, 2022
samhouts
added
the
fixed-in-6.0.200-preview.13.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, we have more mappings registered and they fire after the mapper that fires for FormattedText. Since these other ones also set the AttributedString on the platform control, they override what was in FormattedText.
This changes it so they do not, and FormattedText always takes priority.
Fixes #4172