Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IOSWebViewManager.cs #4158

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Update IOSWebViewManager.cs #4158

merged 3 commits into from
Jan 25, 2022

Conversation

chenrensong
Copy link
Contributor

Description of Change

implement WKUIDelegate into WKWebView in BlazorWebView

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Does this PR touch anything that might affect accessibility?

  • No

implement WKUIDelegate into WKWebView in BlazorWebView
@chenrensong chenrensong requested a review from Eilon as a code owner January 17, 2022 03:24
@dnfadmin
Copy link

dnfadmin commented Jan 17, 2022

CLA assistant check
All CLA requirements met.

@Eilon
Copy link
Member

Eilon commented Jan 17, 2022

Hi @chenrensong thank you for the PR. Can you clarify what scenarios this enables?

@Eilon Eilon added the area-blazor Blazor Hybrid / Desktop, BlazorWebView label Jan 17, 2022
@jsuarezruiz jsuarezruiz added s/needs-info Issue needs more info from the author platform/iOS 🍎 labels Jan 17, 2022
@chenrensong
Copy link
Contributor Author

Hi @chenrensong thank you for the PR. Can you clarify what scenarios this enables?

It mainly solves the BlazorWebView cannot use alert, confirm, etc on IOS or MacOS

@Eilon
Copy link
Member

Eilon commented Jan 18, 2022

@chenrensong OK thank you we will take a look!

@mkArtakMSFT
Copy link
Member

@pranavkm can you please review this? Thanks!

@chenrensong chenrensong requested a review from pranavkm January 22, 2022 02:41
@pranavkm pranavkm enabled auto-merge (squash) January 24, 2022 14:58
@pranavkm
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pranavkm pranavkm merged commit 8b630f8 into dotnet:main Jan 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.200-preview.13.2 Look for this fix in 6.0.200-preview.13.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView fixed-in-6.0.200-preview.13.2 Look for this fix in 6.0.200-preview.13.2! platform/iOS 🍎 s/needs-info Issue needs more info from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants