-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IOSWebViewManager.cs #4158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement WKUIDelegate into WKWebView in BlazorWebView
Hi @chenrensong thank you for the PR. Can you clarify what scenarios this enables? |
It mainly solves the BlazorWebView cannot use alert, confirm, etc on IOS or MacOS |
@chenrensong OK thank you we will take a look! |
@pranavkm can you please review this? Thanks! |
pranavkm
reviewed
Jan 19, 2022
pranavkm
reviewed
Jan 19, 2022
pranavkm
approved these changes
Jan 22, 2022
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-blazor
Blazor Hybrid / Desktop, BlazorWebView
fixed-in-6.0.200-preview.13.2
Look for this fix in 6.0.200-preview.13.2!
platform/iOS 🍎
s/needs-info
Issue needs more info from the author
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
implement WKUIDelegate into WKWebView in BlazorWebView
Additions made
PR Checklist
Does this PR touch anything that might affect accessibility?