-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove no longer used LaunchScreen.xib files from templates #3780
Conversation
Is there any way to test the templates without waiting for them to be released first? |
@jfversluis there's a script in the folder you can use to build the template nuget packages and then you can Just remember to |
Thanks! Adding DNM until I/we verify this doesn't break anything and works when actually changed in the templates |
Tested, all seems to work fine on my end. No errors, and splash screen shows as expected. @chamons were you investigating something on your end for iOS only? |
Yes, I'm hoping to confirm (or refute) that iOS has a bug today. Unfortunately I'm having major issues getting XVS remote builds with NET6 working on my PC, so I'm waiting for help on testing things (to get a binlog). |
But in any case, this PR has no issues FWICT and doesn't have to wait. |
Hi, We have also encountered this issue today with a Maui-Blazor project compiling in Release to an iPhone connected to the (build) Mac (17.1.0 Preview 1.1). We deleted LaunchScreen.xib after reading through the discussions here, but the issue persisted - the same '//' in path e.g. "obj/Release/net6.0-ios/ios-arm64//stripped/Microsoft.Extensions.DependencyInjection.Abstractions.dll". What I can add is that it compiles fine with the above constellation but in Debug and other custom-made types (but not Release). |
@Thomr77 did you use the |
@jfversluis confirming that it builds Release fine with /p:EnableAssemblyILStripping=false - Dank u! |
Awesome @Thomr77 ! Thanks for letting me know! Goed weekend! Voor zover dat gaat met een nieuwe lockdown... 😅 |
Description of Change
Removes (as far as I can tell) unused
LaunchScreen.xib
files from the templates as these were causing issues with the iOS archiving. See related issue.For reference, this is what it looks like, I think this was the default splash screen for new Xamarin apps at some point?
Fixes #3777
Additions made
NA
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.