Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag-drop item reordering to CollectionView #3767 #3768

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

billvenhaus
Copy link
Contributor

Description of Change

Implements drag-drop item reordering for CollectionView #3767

Additions made

  • Changes base class of CollectionView to ReorderableItemsView.
  • Adds CanReorderItems property to ReorderableItemsView.
  • Adds CanMixGroups property to ReorderableItemsView.
  • Adds ReorderCompleted event to ReorderableItemsView.
  • Adds Reordering Galleries to CollectionView Gallery

Pictures

reorderinggallery_android

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the WinUI, Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@jsuarezruiz jsuarezruiz requested a review from hartez December 15, 2021 08:55
@jsuarezruiz jsuarezruiz added area-controls-collectionview CollectionView, CarouselView, IndicatorView t/enhancement ☀️ New feature or request labels Dec 15, 2021
@billvenhaus billvenhaus changed the title Add drag-drop item reordering to CollectionView Add drag-drop item reordering to CollectionView #3767 Dec 15, 2021
@hartez hartez self-assigned this Dec 29, 2021
@hartez hartez added this to the 6.0.200-preview.13 milestone Dec 29, 2021
@Redth Redth removed this from the 6.0.200-preview.13 milestone Jan 26, 2022
@@ -18,6 +18,10 @@ public interface IItemsViewSource : IDisposable

public interface IGroupableItemsViewSource : IItemsViewSource
{
(int, int) GetGroupAndIndex(int position);
Copy link
Contributor

@pictos pictos Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you label those ints in the ValueTuple? To be more explicit on what those means, like (int x, int y)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I just committed the change.

@Redth Redth added this to the 6.0.200-preview.13 milestone Jan 27, 2022
@hartez hartez enabled auto-merge (squash) February 1, 2022 16:11
@hartez
Copy link
Contributor

hartez commented Feb 1, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! t/enhancement ☀️ New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants