Execute Screenshot tests on the main thread #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jsuarezruiz
reviewed
Dec 14, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
PureWeen
force-pushed
the
screenshot_test_fix
branch
from
7ba6fba to
09633ea
Compare
PureWeen
changed the title
drasticactions
approved these changes
Dec 16, 2021
samhouts
added
the
fixed-in-6.0.200-preview.12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There appears to be a timing issue with the screen shot tests where they are running before the scene/view is ready. This changes them to marshal to the main thread so that they will "hopefully" execute in a consistently passing way