Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use android listener and TaskCompletionSource instead of starting new task #3671

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

Redth
Copy link
Member

@Redth Redth commented Dec 6, 2021

The task wrapper is causing a lot of waiting to be reported in nettrace results which makes it difficult to discern where actual hot paths are. This should help that out a bit and maybe speed things up a tiny bit too.

…ew task

The task wrapper is causing a lot of waiting to be reported in nettrace results which makes it difficult to discern where actual hot paths are.  This should help that out a bit and maybe speed things up a tiny bit too.
@Redth Redth requested a review from jonathanpeppers December 6, 2021 15:58
@Redth Redth requested a review from jonathanpeppers December 6, 2021 17:47
@Redth Redth merged commit ffb22d2 into main Dec 6, 2021
@Redth Redth deleted the glide-use-listener branch December 6, 2021 20:03
@samhouts samhouts added area-image Image loading, sources, caching area-controls-image Image control platform/android 🤖 labels Jul 10, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
@Eilon Eilon removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-image Image loading, sources, caching labels May 10, 2024
@samhouts samhouts added the fixed-in-6.0.200-preview.12 Look for this fix in 6.0.200-preview.12! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-image Image control fixed-in-6.0.200-preview.12 Look for this fix in 6.0.200-preview.12! platform/android 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants