Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RefreshViewHandler on Windows #3299

Merged
merged 17 commits into from
Feb 24, 2022
Merged

Implement RefreshViewHandler on Windows #3299

merged 17 commits into from
Feb 24, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Nov 8, 2021

Description of Change

Implement RefreshViewHandler on Windows.

Currently the sample that's part of our gallery doesn't work with gestures because of this issue
#3848

If you add a RefreshView to a different page (like the ButtonPage) you can see that it works with a gesture

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Does this PR touch anything that might affect accessibility?

  • No

@jsuarezruiz jsuarezruiz added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Nov 8, 2021
@rmarinho rmarinho requested a review from PureWeen November 11, 2021 13:40
@jsuarezruiz jsuarezruiz marked this pull request as ready for review December 13, 2021 11:59
@PureWeen PureWeen force-pushed the refreshview-windows branch from e33c4f3 to 8d53367 Compare December 22, 2021 22:44
@PureWeen PureWeen enabled auto-merge (squash) December 22, 2021 22:45
PureWeen
PureWeen previously approved these changes Dec 22, 2021
@PureWeen PureWeen disabled auto-merge December 22, 2021 23:08
@PureWeen PureWeen self-requested a review December 23, 2021 00:17
@PureWeen PureWeen dismissed their stale review December 23, 2021 00:17

Still needs work

@Eilon Eilon added the area-controls-refreshview RefreshView label Feb 11, 2022
@PureWeen PureWeen enabled auto-merge (squash) February 24, 2022 22:49
@PureWeen PureWeen merged commit 634bda4 into main Feb 24, 2022
@PureWeen PureWeen deleted the refreshview-windows branch February 24, 2022 23:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-refreshview RefreshView fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants