[Testing] Disable system animations to save test execution time #27370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- src/TestUtils/src/UITest.Appium/ShellHelper.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/TestUtils/src/UITest.Appium/Actions/AppiumCatalystSpecificActions.cs:36
- Ensure that the new ToggleSystemAnimations functionality is covered by tests.
ToggleSystemAnimationsCommand => ToggleSystemAnimations(parameters),
rmarinho
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Disable system animations to save test execution time.
Appium operates as a robot devoid of features like animations that consume time. The time spent waiting for them to conclude becomes entirely futile. Also, animations can introduce instability to our testing process by creating race conditions, necessitating the use of waits or other workarounds.
This PR introduce changes to disable system animations on Android and Catalyst. In Catalyst, each test verifying snapshots puts the app in full screen which involves a time-consuming animation. The goal is to reduce execution time.