Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GetDrawableAsync for release #26983

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jan 7, 2025

Description of Change

We disabled this test on release mode for device tests.

Checking to see if this exception is still happening

Fixes

@Copilot Copilot bot review requested due to automatic review settings January 7, 2025 16:11
@PureWeen PureWeen requested a review from a team as a code owner January 7, 2025 16:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Core/tests/DeviceTests/Services/ImageSource/StreamImageSourceServiceTests.Android.cs:25

  • Ensure that the test case is properly covered in both TestCases.HostApp and TestCases.Shared.Tests.
[Theory]
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these types of PRs!

@PureWeen PureWeen merged commit 68c7dc7 into main Jan 7, 2025
102 of 104 checks passed
@PureWeen PureWeen deleted the PureWeen/EnableStreamImageSourceTestRelease branch January 7, 2025 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants